Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No Preview" Shown when switching between components #6555

Closed
bennypowers opened this issue Apr 17, 2019 · 7 comments
Closed

"No Preview" Shown when switching between components #6555

bennypowers opened this issue Apr 17, 2019 · 7 comments

Comments

@bennypowers
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Install v5.1.0-alpha.29
  2. Create multiple stories using '@storybook/polymer'
  3. run storybook
  4. Load storybook in browser - first shown story is fine
  5. Switch to another story in the side bar menu
  6. Second story displays, but so does "No Preview" alert.

Expected behavior
"No Preview" should only show when there is no preview.

Screenshots
no-preview-out

Code snippets
If applicable, add code samples to help explain your problem.

System:

  • OS: MacOS
  • Device: Macbook Pro 2018
  • Browser: FF, Chrome
  • Framework: Web-components (polymer package)
  • Addons: a11y, actions, backgrounds, console, knobs, links, notes, options, storysource, viewport
  • Version: 5.1.0-alpha.29
@shilman shilman added this to the 5.1.0 milestone Apr 18, 2019
@shilman
Copy link
Member

shilman commented Apr 22, 2019

It's showing "no preview" for me the whole time on your storybook (private link). Hopefully one of our polymer gurus can give a look!

@stale stale bot added the inactive label May 13, 2019
@shilman shilman removed the inactive label May 13, 2019
@bennypowers
Copy link
Contributor Author

Confirming this bug still exits with storybook 5.1.0-rc.0

@storybookjs storybookjs deleted a comment from stale bot May 24, 2019
@ndelangen ndelangen self-assigned this May 24, 2019
@ndelangen
Copy link
Member

I'm not able to reproduce the behavior in the polymer-cli example. @bennypowers if I could take a look at the example too, I might be able to help here. 🙇

@bennypowers
Copy link
Contributor Author

@ndelangen Thanks for writing. I sent you a PM on storybook's discord with the link to the (private for now) storybook. Thanks for the interest

@shilman shilman modified the milestones: 5.1.0, 5.1.x Jun 5, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 26, 2019
@bennypowers
Copy link
Contributor Author

I was unable to reproduce with storybook 5.1.3. Closing for now. If it comes back once I succeed at building newer versions (#7084) I'll reopen

@ndelangen
Copy link
Member

Thanks for reporting @bennypowers 🙇

I sure hope the issues stays closed, but obviously happy to assist if it does crop up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants