Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to inject middleware so addons can become much smarter #638

Closed
ndelangen opened this issue Dec 4, 2016 · 2 comments
Closed

Comments

@ndelangen
Copy link
Member

Currently addons have access to the 'Manager App' and the 'Preview Area'.

Adding an ability to inject custom (express) middleware would open up even more opportunities for creative addon-creators.

These custom middlewares can provide storybook with new features by enabling additional data retrieval for addons.

Some data examples of data:

  • unit tests
  • package / dependencies version & updates
  • package dependency graph
  • git & other system integrations

I don't think it's all that hard to implement via config.js.

@thani-sh
Copy link
Contributor

thani-sh commented Dec 5, 2016

Hi @ndelangen
There's an open pull request for this feature #435. It does this using a middleware.js file. If we use the config.js file for middleware, it may add server side code to the javascript bundle it builds for the client.

@arunoda
Copy link
Member

arunoda commented Dec 5, 2016

I think we can close this as we are working on this with #435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants