Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-knobs] perfomances issues especially when editing text or numbers #6096

Closed
sangbpark94 opened this issue Mar 14, 2019 · 6 comments
Closed

Comments

@sangbpark94
Copy link

Describe the bug
Using @storybook/addon-knobs in a storybook created with React and experiencing performance issues, especially when editing text or number. Here is a simple example of a story that I used:

storiesOf('Components', module) .addDecorator(withKnobs) .add('with editable text', () => <div>{text('Text', 'Some text')}</div> )

To Reproduce
Steps to reproduce the behavior:

Just go to this example storybook built in React, go to the Knobs tab, and edit the "optional" text:

https://storybooks-official.netlify.com/?path=/story/addons-knobs-withknobs--dynamic-knobs

When you start doing a mix of typing and erasing text, some of your text disappears or previously written text is suddenly added.

This storybook was the first example given for Storybook 5.0 found on the main storybook website:

https://storybook.js.org/docs/basics/live-examples/

Expected behavior
Edit the text without having some text removed or added while typing.

System:

  • OS: MacOS
  • Device: Macbook Pro 2015
  • Browser: Chrome
  • Framework: react
  • Addons: Knobs
  • Version: 5.0.x
@hrishikeshpotdar91
Copy link

Facing the exact same issue.

@CodeByAlex
Copy link
Member

@sanbpark94 & @ruudyroon Which version are you using?

@shilman shilman added this to the 5.0.x milestone Mar 15, 2019
@shilman
Copy link
Member

shilman commented Mar 15, 2019

Looks like I need to release a stable version with this fix: #6022

@sangbpark94 @ruudyroon Would you mind trying out the latest 5.1-alpha?

I'll release the fix on latest later today.

@sangbpark94
Copy link
Author

Just gave v5.1.0-alpha.6 a test and it looks like the bug is resolved!

@shilman
Copy link
Member

shilman commented Mar 15, 2019

Thanks for testing it out @sangbpark94!

@Armanio
Copy link
Member

Armanio commented Mar 17, 2019

It seems all is well. Closed.

@Armanio Armanio closed this as completed Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants