@storybook/[email protected] breaks module resolving if react folder in user sources

[galefebvre-adeo]

Describe the bug

Having a src/react folder in the user sources breaks absolute imports with @storybook/[email protected].

To Reproduce
Steps to reproduce the behavior:

1. Install latest yarn add -D @storybook/[email protected].
2. Create a component in src/react/components/Button.jsx.
3. Import this component from a story.
4. Launch storybook start-storybook -p 9001 -c .storybook.
5. Error in console Module not found: Error: Can't resolve 'react/components/Button' in XXX.

Expected behavior
The storybook builds fine.

System:

• OS: Windows10
• Framework: react
• Version: 4.1.6

Additional context
This comes from this PR: #5148, specifically line 87 of lib/core/src/server/preview/iframe-webpack.config.js. It adds an alias of react to node_modules/react to make sure to import the react version of the user instead of the version used by the storybook ui. The problem is that webpack doesn't lookup the folders specified in resolve.modules (i.e. src) if it finds that the imported path matches an alias.

For the time being I simply overrode the webpack config in .storybook/webpack.config.js to remove the react alias since I'm using the same version as storybook.

// .storybook/webpack.config.js
module.exports = (baseConfig, env, defaultConfig) => {
  delete defaultConfig.resolve.alias.react;
  return defaultConfig;
};

This is not ideal since it basically removes the feature of importing the user react version. Not sure how to fix this besides changing the src/react folder name, but that makes storybook enforce an arbitrary rule to the user code base.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[mpelekh]

The same issue exists with storybook/[email protected] as well.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!