Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-info] PropTypes missing for build-storybook #3943

Closed
rwieruch opened this issue Aug 1, 2018 · 5 comments
Closed

[addon-info] PropTypes missing for build-storybook #3943

rwieruch opened this issue Aug 1, 2018 · 5 comments

Comments

@rwieruch
Copy link
Contributor

rwieruch commented Aug 1, 2018

In my development environment, addon-info works perfectly fine. It shows the PropTypes for each component:

screen shot 2018-08-01 at 17 02 05

However, once I build the Storybook for production with build-storybook -c .storybook -o dist and deploy it, the PropTypes are empty:

screen shot 2018-08-01 at 17 02 13

Anything I can do about it? That's one of my components:

...

const ContentButton = ({ onClick, children, className, ...props }) => (
    <BaseButton
      onClick={onClick}
      className={cs(className, 'content')}
      {...props}
    >
      {children}
    </BaseButton>
);

ContentButton.propTypes = {
  onClick: PropTypes.func.isRequired,
  children: PropTypes.string.isRequired,
  className: PropTypes.string,
};

ContentButton.displayName = 'ContentButton';

export default ContentButton;

Any help is really appreciated.

@kylemh
Copy link
Member

kylemh commented Aug 3, 2018

Do you potentially have a babel plugin or are you using a library that's stripping propTypes from a bundle in prod?

@rwieruch
Copy link
Contributor Author

rwieruch commented Aug 3, 2018

I wouldn't be aware of it.

.babelrc

{
  "presets": [
    "env",
    "react",
    "stage-2",
  ],
  "env": {
    "test": {
      "presets": [
        "env",
        "react",
        "stage-2",
      ],
      "plugins": ["require-context-hook"]
    }
  }
}

webpack.config.js in .storybook/

module.exports = (storybookBaseConfig, configType) => {
  storybookBaseConfig.module.rules.push(
    {
      test: /\.(js|jsx)$/,
      exclude: /node_modules/,
      use: ['babel-loader'],
    },
    {
      test: /\.(woff(2)?|ttf|eot)(\?v=\d+\.\d+\.\d+)?$/,
      use: ['file-loader'],
    },
    {
      test: /stories\.(js|jsx)?$/,
      loaders: [require.resolve('@storybook/addon-storysource/loader')],
      enforce: 'pre',
    },
  );

  return storybookBaseConfig;
};

@danielduan
Copy link
Member

danielduan commented Aug 3, 2018

related to #1661

@stale
Copy link

stale bot commented Aug 24, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Aug 24, 2018
@stale
Copy link

stale bot commented Sep 23, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants