Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyshot should run tests in parallel #3802

Closed
testerez opened this issue Jun 26, 2018 · 6 comments
Closed

Storyshot should run tests in parallel #3802

testerez opened this issue Jun 26, 2018 · 6 comments

Comments

@testerez
Copy link
Contributor

testerez commented Jun 26, 2018

I noticed that our storyshots test suite is taking about 13s. Making it by far the slowest test of our project.
From my understanding, jest runs all storyshots tests in a single process because it's declared in a single file. I'm not sure what would be the best way to achieve it but taking advantage of Jest parallelism would probably make things a lot faster.

@igor-dv
Copy link
Member

igor-dv commented Jun 27, 2018

AFAIR, the most problematic place that takes time is not a tests run, but the storybook initialization. Profiling will help to understand though

@testerez
Copy link
Contributor Author

Are you aware of an easy way to profile @igor-dv ?

@stale
Copy link

stale bot commented Jul 18, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 18, 2018
@stale
Copy link

stale bot commented Aug 17, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Aug 17, 2018
@patthiel
Copy link

patthiel commented Oct 3, 2018

@testerez did you ever manage to get the tests to run in parallel?

@testerez
Copy link
Contributor Author

testerez commented Oct 3, 2018

No @patthiel I didn't try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants