Actions addon doesn't work on Edge

[dietergeerts]

Bug or support request summary

I'm just setting up Storybook, and tried the MyButton example with the Actions addon. This works on Chrome, but not on Edge. The actions aren't outputted, and no error is being logged on the console.

Steps to reproduce

Run the Vue MyButton example on Edge

Please specify which version of Storybook and optionally any affected addons that you're running

    "@storybook/addon-actions": "3.4.6",
    "@storybook/vue": "3.4.6",
    "babel-core": "6.26.3",
    "vue-loader": "14.2.3",
    "vue-template-compiler": "2.5.16"

Affected platforms

• Edge browser

[danielduan]

Looks like we're using WeakMap.set() which Edge 15 doesn't support?
http://kangax.github.io/compat-table/es6/#test-WeakMap

@rhalff ?

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[rhalff]

Sorry, I've only just now noticed this issue, I'll have a look.

[rhalff]

@danielduan which versions of edge need to be supported?

The lack of WeakMap can propably be solved by adding a polyfill for it, this could be done at the place wherever storybook is currently adding the polyfills.

My current virtualbox vm is running Microsoft EdgeHTML 16.16299 which doesn't give the above error.
It does bail out on trying to access the console.memory property though, it throws a warning and then does not log anything.

I could hook in some browser specific tests to solve 'edge' cases. Most of those will be iterable properties which shouldn't be accessed. Firefox has some of those also, but will just throw a warning in the console and doesn't choke.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[danielduan]

Wonder if we need to explicitly include it in our Babel env config.

I think support policy Is whatever the current browserslist default is.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!