Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publicPath. #344

Closed
arunoda opened this issue Aug 1, 2016 · 3 comments
Closed

Add support for publicPath. #344

arunoda opened this issue Aug 1, 2016 · 3 comments

Comments

@arunoda
Copy link
Member

arunoda commented Aug 1, 2016

When deploying to production sites, it's better to provide a public URL. We can use webpack's publicPath field for that.

We can provide a cli argument for this. React Create App looks for the homepage field of the package.json for this.

@arunoda
Copy link
Member Author

arunoda commented Sep 15, 2016

We don't use this and we don't need this.
You can deploy to any domain without any issues.

But for images, you need to do something. Check this: https://storybook.js.org/configurations/serving-static-files#absolute-versus-relative-paths

@arunoda arunoda closed this as completed Sep 15, 2016
@ccutch
Copy link

ccutch commented Aug 24, 2017

Link is broken

@Hypnosphi
Copy link
Member

@ccutch thanks, updated that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants