Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiSnapshotWithOptions names snapshot like first file in current folder #3152

Closed
oldwin opened this issue Mar 5, 2018 · 7 comments
Closed

Comments

@oldwin
Copy link

oldwin commented Mar 5, 2018

Issue details

I'm using multiSnapshotWithOptions to generate multiple snapshots

initStoryshots({
  test: multiSnapshotWithOptions({}),
});

For example I have next stories in the folder

folder/BBB.stories.js

storiesOf('myStory', module)
  .add('BBB', () => (

folder/CCC.stories.js

storiesOf('myStory', module)
  .add('CCC', () => (

I expect storyshot will create snapshot file with name 'myStory' or two files for BBB and CCC. But it creates snapshots/BBB.stories.storyshot (just first file in the folder in alphabetical order).

If I will create file AAA.stories.js and update snapshots it will remove snapshots/BBB.stories.storyshot and create new wile snapshots/AAA.stories.storyshot

Please specify which version of Storybook and optionally any affected addons that you're running

  • storybook/addon-actions: 3.3.14
  • storybook/addon-knobs: 3.3.14
  • storybook/addon-storyshots: 3.3.14
  • storybook/addons: 3.3.14
  • storybook/react: 3.3.14
@igor-dv
Copy link
Member

igor-dv commented Mar 6, 2018

I am going to work on storyshots after the 3.4. One of the things is to make multisnapshot more configurable.
CC. #2517

@stale
Copy link

stale bot commented Mar 27, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 27, 2018
@oldwin
Copy link
Author

oldwin commented Apr 20, 2018

@igor-dv hi, any updates? Maybe I can help with something?

@stale stale bot removed the inactive label Apr 20, 2018
@igor-dv
Copy link
Member

igor-dv commented Apr 22, 2018

Still didn't manage to work on the refactoring, but you are welcome to help

@stale
Copy link

stale bot commented May 13, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@igor-dv
Copy link
Member

igor-dv commented Jun 13, 2018

Will be able to do with extending the Stories2SnapsConverter.

@igor-dv igor-dv closed this as completed Jun 23, 2018
@issue-sh issue-sh bot removed merged labels Jun 23, 2018
@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants