Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from handlebars to simple string concats #29167

Closed
Tracked by #29038
JReinhold opened this issue Sep 19, 2024 · 0 comments · Fixed by #29208
Closed
Tracked by #29038

Migrate from handlebars to simple string concats #29167

JReinhold opened this issue Sep 19, 2024 · 0 comments · Fixed by #29208
Assignees

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Sep 19, 2024

handlebars is part of @storybook/core despite only being used in a single place in builder-webpack5:

  1. https://github.com/storybookjs/storybook/blob/next/code/builders/builder-webpack5/src/preview/virtual-module-mapping.ts/#L54-L66
  2. https://github.com/storybookjs/storybook/blob/next/code/builders/builder-webpack5/templates/virtualModuleModernEntry.js.handlebars

Our use case for it is so simple that builder-vite just manually builds the string with simple template strings: https://github.com/storybookjs/storybook/blob/next/code/builders/builder-vite/src/codegen-modern-iframe-script.ts

We should migrate the Webpack builder to do the same, and get rid of handlebars altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants