Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Storybook 8 notifications uses deprecated icons #26436

Closed
yannbf opened this issue Mar 12, 2024 · 1 comment · Fixed by #26477
Closed

[Bug]: Storybook 8 notifications uses deprecated icons #26436

yannbf opened this issue Mar 12, 2024 · 1 comment · Fixed by #26477
Assignees
@cdedreuille
Labels
bug ui
Milestone
8.0-stabilization

Comments

@yannbf
Copy link
Member

yannbf commented Mar 12, 2024

Describe the bug

As can be seen in the image:

image

Location:

storybook/code/ui/manager/src/components/notifications/NotificationItem.tsx

Line 85 in 7a10141

<Icons

To Reproduce

No response

System

No response

Additional context

No response
@JReinhold JReinhold added this to the 8.0-stablization milestone Mar 12, 2024
@SalahAdDin
Copy link

I saw and reported this issue in Discord, totally agree with this!

@yannbf yannbf moved this to In Progress in Core Team Projects Mar 13, 2024
@cdedreuille cdedreuille mentioned this issue Mar 13, 2024
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdedreuille cdedreuille

Labels
bug ui
Projects
Core Team Projects
Archived in project
Storybook 8.0 Roadmap
Status: Done
Milestone
8.0-stabilization
Development

Successfully merging a pull request may close this issue.

UI: Replace the icon prop in the Manager API storybookjs/storybook
4 participants
@cdedreuille @yannbf @SalahAdDin @JReinhold