Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when argTypesRegex is used together with the visual test addon #25405

Closed
valentinpalkovic opened this issue Jan 2, 2024 · 1 comment · Fixed by #26094
Closed

Warn when argTypesRegex is used together with the visual test addon #25405

valentinpalkovic opened this issue Jan 2, 2024 · 1 comment · Fixed by #26094
Assignees
@kasperpeulen
Milestone
8.0-RC

Comments

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Jan 2, 2024 •
edited by kasperpeulen
Loading

The visual test addon should show a warning when argTypesRegex is used.

We can log the warning in the preset.
@valentinpalkovic valentinpalkovic mentioned this issue Jan 2, 2024
Closed
@valentinpalkovic
Copy link
Contributor Author

valentinpalkovic commented Jan 12, 2024 •
edited
Loading

We haven't had time to deal with this. We should plan this for the v8 Release project. It is needed for GA, but it's technically not a breaking change.

cc @vanessayuenn

@vanessayuenn vanessayuenn added this to the 8.0-RC milestone Jan 15, 2024
@vanessayuenn vanessayuenn moved this to Empathy Backlog in Core Team Projects Feb 13, 2024
@vanessayuenn vanessayuenn moved this from Empathy Backlog to Empathy - Ready for work in Core Team Projects Feb 13, 2024
@kasperpeulen kasperpeulen mentioned this issue Feb 19, 2024
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from Empathy - Ready for work to Done in Core Team Projects Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperpeulen kasperpeulen

Labels
None yet
Projects
Core Team Projects
Archived in project
Storybook 8.0 Roadmap
Status: Done
Milestone
8.0-RC
Development

Successfully merging a pull request may close this issue.

Addon-actions: Warn when argTypesRegex used with visual test addon storybookjs/storybook
3 participants
@kasperpeulen @valentinpalkovic @vanessayuenn