Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated serverChannel implementations #25366

Closed
Tracked by #25331
yannbf opened this issue Dec 28, 2023 · 2 comments · Fixed by #25536
Closed
Tracked by #25331

Remove deprecated serverChannel implementations #25366

yannbf opened this issue Dec 28, 2023 · 2 comments · Fixed by #25536
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented Dec 28, 2023

serverChannel:

private serverChannel: Channel | undefined;

setServerChannel:

setServerChannel = (channel: Channel): void => {

hasServerChannel:

hasServerChannel = (): boolean => !!this.serverChannel;

getServerChannel:

getServerChannel = (): Channel => {

Seems like this change is going to be a little more involved, so here's the PR that introduced it for more context: #22940

@shilman
Copy link
Member

shilman commented Dec 29, 2023

Cc @ndelangen

@ndelangen
Copy link
Member

I'm fairly sure, nothing uses these methods anymore, so it's likely fine to remove them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants