Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated props from Source block #25336

Closed
Tracked by #25331
yannbf opened this issue Dec 27, 2023 · 1 comment · Fixed by #25459
Closed
Tracked by #25331

Remove deprecated props from Source block #25336

yannbf opened this issue Dec 27, 2023 · 1 comment · Fixed by #25459
Assignees
@valentinpalkovic

Comments

@yannbf
Copy link
Member

yannbf commented Dec 27, 2023 •
edited
Loading

It's unclear whether to remove these deprecated properties from the Source block component in Storybook 8:

storybook/code/ui/blocks/src/blocks/Source.tsx

Line 63 in 07145b6

/** @deprecated use of={storyExport} instead */

@JReinhold please let us know whenever you can 🙏
@yannbf yannbf mentioned this issue Dec 27, 2023
Closed
@JReinhold
Copy link
Contributor

Yes, remove them.

@JReinhold JReinhold changed the title Determine whether to remove deprecated props from Source block Remove deprecated props from Source block Jan 3, 2024
@yannbf yannbf self-assigned this Jan 4, 2024
@yannbf yannbf mentioned this issue Jan 4, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc blocks: Remove deprecated props from Source block storybookjs/storybook
3 participants
@yannbf @JReinhold @valentinpalkovic