Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Drag handle makes closing a notification difficult #24996

Open
MichaelArestad opened this issue Nov 27, 2023 · 6 comments
Open

[Bug]: Drag handle makes closing a notification difficult #24996

MichaelArestad opened this issue Nov 27, 2023 · 6 comments

Comments

@MichaelArestad
Copy link
Contributor

Describe the bug

I think the z-index of the sidebar drag handle is too high or the notification z-index is too low. In just the right circumstances, the drag handle will obstruct the close button on the notification. Here's a quick video demonstrating this:

Screenshare.-.2023-11-27.11_01_36.AM.mp4

To Reproduce

You might need to do this locally. I was advised to delete the storybook cache in node_modules to get the notification to appear. Then, drag the sidebar to align with the close button.

System

Storybook Environment Info:

  System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.19.0/bin/yarn <----- active
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.6.2 - ~/.nvm/versions/node/v16.19.0/bin/pnpm
  Browsers:
    Chrome: 119.0.6045.159
    Edge: 119.0.2151.72
    Safari: 17.0
  npmPackages:
    @storybook/addon-actions: 7.4.2 => 7.4.2 
    @storybook/addon-designs: ^7.0.5 => 7.0.5 
    @storybook/addon-essentials: 7.4.2 => 7.4.2 
    @storybook/addon-interactions: 7.4.2 => 7.4.2 
    @storybook/addon-mdx-gfm: 7.4.2 => 7.4.2 
    @storybook/channels: 7.4.2 => 7.4.2 
    @storybook/client-logger: 7.4.2 => 7.4.2 
    @storybook/design-system: ^7.15.15 => 7.15.15 
    @storybook/eslint-config-storybook: ^3.1.2 => 3.1.2 
    @storybook/jest: ^0.2.2 => 0.2.2 
    @storybook/manager-api: 7.4.2 => 7.4.2 
    @storybook/react: 7.4.2 => 7.4.2 
    @storybook/react-vite: 7.4.2 => 7.4.2 
    @storybook/testing-library: ^0.2.1-next.0 => 0.2.1 
    @storybook/theming: 7.4.2 => 7.4.2 
    chromatic: ^9.0.0 => 9.0.0 
    eslint-plugin-storybook: ^0.6.13 => 0.6.13 
    msw-storybook-addon: 2.0.0--canary.122.b3ed3b1.0 => 2.0.0--canary.122.b3ed3b1.0 
    storybook: 7.4.2 => 7.4.2

Additional context

No response

@karthiknadar1204
Copy link

If this issue is up for grabs, I would like to work on it,please assign it to me

@shilman
Copy link
Member

shilman commented Dec 25, 2023

@karthiknadar1204 Thank you for helping make Storybook better! 🙏 Please check out how to contribute in our docs and feel free to ask questions in #contributing in our Discord.

@PrayanshParmar
Copy link

Hey I would like to resolve this issue.

@Vicente2019
Copy link

Hey, is this issue still in need of help?

@arp55
Copy link

arp55 commented Mar 22, 2024

Hi, is this issue still open? Would like to help

@aqandrew
Copy link

I attempted to repro the issue by deleting the cache based on this comment, but I'm not able to get that What's new in Storybook... notification to pop up.

However, this Connection lost one pops up if yarn start is exited. The drag handles / z-index appear to be working normally. Is this still an issue?

Screen.Recording.2024-03-22.at.12.08.22.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants