Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to style the IconItem component #24764

Open
pedaars opened this issue Nov 8, 2023 · 8 comments
Open

[Bug]: Unable to style the IconItem component #24764

pedaars opened this issue Nov 8, 2023 · 8 comments

Comments

@pedaars
Copy link

pedaars commented Nov 8, 2023

Describe the bug

I am unable to style the IconItem component which is causing issues with long icon names that my team insist on using such as StarfighterTwinIonEngineAdvanced

which results in
Screenshot 2023-11-08 at 14 36 45

To Reproduce

https://stackblitz.com/edit/github-mtjcjc?file=src%2Fstories%2FIconography.mdx

System

Environment Info:

  System:
    OS: macOS 14.1
    CPU: (12) arm64 Apple M2 Pro
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
  Browsers:
    Edge: 119.0.2151.46
    Safari: 17.1
  npmPackages:
    @storybook/addon-a11y: ^7.0.10 => 7.3.1 
    @storybook/addon-console: ^1.2.3 => 1.2.3 
    @storybook/addon-essentials: ^7.0.8 => 7.3.1 
    @storybook/addon-interactions: ^7.0.8 => 7.3.1 
    @storybook/addon-jest: ^7.0.10 => 7.3.1 
    @storybook/addon-links: ^7.0.8 => 7.3.1 
    @storybook/addon-storysource: ^7.0.11 => 7.3.1 
    @storybook/addons: ^7.0.8 => 7.3.1 
    @storybook/blocks: ^7.0.8 => 7.3.1 
    @storybook/react: ^7.0.8 => 7.3.1 
    @storybook/react-webpack5: ^7.0.8 => 7.3.1 
    @storybook/theming: ^7.0.8 => 7.3.1

Additional context

No response

@valentinpalkovic
Copy link
Contributor

@cdedreuille Can you take a look?

@pedaars
Copy link
Author

pedaars commented Nov 17, 2023

Any update on this?

@cdedreuille cdedreuille self-assigned this Nov 19, 2023
@cdedreuille
Copy link
Contributor

Thanks for sharing this bug. I confirm that I can reproduce it and that's definitely not ideal. For now I would suggest creating your custom list of icons if the icon gallery isn't working for you. We have a couple of improvements we would like to bring to this block but I can't guarantee that it will be prioritised soon.

I assigned it to me so I can have a look in the coming weeks. I you or someone wants to take a shot at improving it, this could be a good first issue.

@ananta
Copy link

ananta commented Nov 29, 2023

@cdedreuille I would love to work on this 😄

image

This is a quick fix that I came up with. However, I would love to get your guidance to ensure it aligns with the project's standards.

@kristttinee
Copy link

I'd like to have this issue as my first issue, please could you assign it to me?

@riya-rjha
Copy link

Hi there! I'd like to work on this. Could you please assign it to me?

@shilman
Copy link
Member

shilman commented Dec 25, 2023

Thank you for helping make Storybook better -- no need to be assigned to an issue to work on it! 🙏 Please check out how to contribute in our docs and feel free to ask questions in #contributing in our Discord.

@koskosergej
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants