Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Setup controls >" URL cannot be disabled #24475

Closed
hieucd04 opened this issue Oct 14, 2023 · 4 comments · Fixed by #26120
Closed

[Bug]: "Setup controls >" URL cannot be disabled #24475

hieucd04 opened this issue Oct 14, 2023 · 4 comments · Fixed by #26120

Comments

@hieucd04
Copy link

hieucd04 commented Oct 14, 2023

Describe the bug

I followed this guide: https://storybook.js.org/docs/react/essentials/controls#disable-controls-for-specific-properties
... where I explicitly set control: false as mentioned there and it works. However, when I hover my mouse over the disabled control a Setup controls > URL is displayed.

Currently, at Storybook 7.4.6, there are no way to disable that behavior (... or my Googling skill isn't good enough?).
That URL appears in production build of Storybook as well (sb build -o out-dir) which is pointless from my perspective. How come our clients, who know nothing about coding and only care about the beauty of React components, need to view that URL?

link

@valentinpalkovic
Copy link
Contributor

@cdedreuille Can you take a look? It seems that "Setup controls" doesn't respect, whether a control field is disabled or not.

@peschee
Copy link
Contributor

peschee commented Dec 13, 2023

Using

control: { 
  type: {}
}

removes the link.

control: {
  type: {},
  disable: true
}

does not

@cdedreuille
Copy link
Contributor

I confirm that the disable property was not added to the "setup control" link when we added this feature. I'll take this one on to make sure it does.

@cdedreuille
Copy link
Contributor

We just talked about this with @kasperpeulen and he is taking over this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
6 participants