Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After upgrade to Storybook 7.4.4 has bug, browser blocked #24275

Closed
eneaaliko0 opened this issue Sep 22, 2023 · 13 comments · Fixed by #24291
Closed

[Bug]: After upgrade to Storybook 7.4.4 has bug, browser blocked #24275

eneaaliko0 opened this issue Sep 22, 2023 · 13 comments · Fixed by #24291
Assignees

Comments

@eneaaliko0
Copy link

eneaaliko0 commented Sep 22, 2023

Describe the bug

Screenshot 2023-09-22 at 3 48 35 PM

To Reproduce

No response

System

System:
    OS: macOS 13.5.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 16.15.0 - ~/node_modules/.bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.6

Additional context

"@vitejs/plugin-react": "^3.1.0",
"@storybook/builder-vite": "^7.4.4",
"@rollup/plugin-commonjs": "^22.0.0",
"@storybook/client-api": "^7.4.4",
"@storybook/addon-actions": "^7.4.4",
"@storybook/addon-essentials": "^7.4.2",
"@storybook/addon-links": "^7.4.4",
"@storybook/addon-styling": "^1.3.7",
"@storybook/addons": "^7.4.4",
"@storybook/mdx1-csf": "^1.0.0",
"@storybook/react": "^7.4.4",
"@storybook/cli": "^7.4.4",
"@storybook/react-vite": "^7.4.4",
@eneaaliko0
Copy link
Author

maybe, this is the problem in last merge

@eneaaliko0 eneaaliko0 changed the title [Bug]: After upgrade to Storybook 7.4.4 has bug, browser blocked [Bug]: After upgrade to Storybook 7.4.4 has bug, browser blocked Sep 22, 2023
@mnicholstamu
Copy link

mnicholstamu commented Sep 22, 2023

I am running into the same issues. We moved back to Storybook 7.4.3 for the time being.

@ritterb82
Copy link

ritterb82 commented Sep 22, 2023

+1, Seeing same issues.

For me, would work fine with:

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials'],

But as soon as I added @storybook/addon-a11y, it would break.

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials', '@storybook/addon-a11y']

@mnicholstamu
Copy link

+1, Seeing same issues.

For me, would work fine with:

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials'],

But as soon as I added @storybook/addon-a11y, it would break.

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials', '@storybook/addon-a11y']

I wonder if we are all using the a11y addon... I just removed it from our 7.4.4 branch and it's working fine now.

@joelpierre
Copy link

Happening to me as well. Having to revert back to previous version 😢

@boar-is
Copy link

boar-is commented Sep 23, 2023

Same, removing @storybook/addon-themes/@storybook/addon-styling helps.

Related: #24273

@liuxian496
Copy link

liuxian496 commented Sep 24, 2023

+1, Seeing same issues. This is “main.ts” in my project.

import type { StorybookConfig } from "@storybook/react-webpack5";
const config: StorybookConfig = {
  stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-interactions",
    {
      name: '@storybook/preset-create-react-app',
      options: {
        craOverrides: {
          fileLoaderExcludes: ['less']
        }
      }
    },
    {
      name: '@storybook/addon-coverage',
      options: {
        istanbul: {
          include: ['**'],
          exclude: ['**/src/test/**'],
          excludeNodeModules: true,
        },
      },
    },
    {
      name: '@storybook/addon-styling',
      options: {
        less: {
          // Require your Less preprocessor here
          implementation: require('less')
        }
      }
    }, "@storybook/addon-mdx-gfm"],
  framework: {
    name: "@storybook/react-webpack5",
    options: {}
  },
  docs: {
    autodocs: 'tag'
  },
  staticDirs: ["../public"]
};
export default config;

@mfc-admin
Copy link

+1, Seeing same issues.

For me, would work fine with:

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials'],

But as soon as I added @storybook/addon-a11y, it would break.

addons: ['@storybook/preset-create-react-app', '@storybook/addon-essentials', '@storybook/addon-a11y']

Yes, got the same error when adding addon-a11y.

@yannbf
Copy link
Member

yannbf commented Sep 24, 2023

Hey everyone! Thank you so much for reporting this issue, and especially @eneaaliko0 for spotting where bug got introduced. We will be releasing a fix as soon as we can.

In the meantime, please downgrade to 7.4.3.

@shilman shilman added the ui label Sep 24, 2023
@eneaaliko0
Copy link
Author

Hey everyone! Thank you so much for reporting this issue, and especially @eneaaliko0 for spotting where bug got introduced. We will be releasing a fix as soon as we can.

Thank you so much for your support @yannbf ! 🙏

@shilman
Copy link
Member

shilman commented Sep 24, 2023

We're having some problems getting a release out, so until we do please pin your dependency to 7.4.3. Thank you for your patience!

@shilman shilman moved this to In Progress in Core Team Projects Sep 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Sep 24, 2023
@shilman
Copy link
Member

shilman commented Sep 24, 2023

Ok hopefully fixed in https://github.com/storybookjs/storybook/releases/tag/v7.4.5. Thanks @yannbf !

@Kosai106
Copy link
Contributor

Kosai106 commented Sep 25, 2023

@shilman I just spun up a new Storybook and I'm still having this issue on 7.4.5 as soon as I add addon-a11y 😢

Edit: Nevermind, I updated my addons but not Storybook itself... 🤦‍♂️ False alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.