-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Keyboard focus is not visible While invoking the “Tests completed” button. #24129
Comments
I can take a look at this 😊 |
Having some trouble building up a sandbox with my local code for the a11y package can anyone point me in the right direction ? @shilman |
Hey there! 👋 I'm new to open source and super excited to dive in! I'd love to work on this. Can I be assigned to this issue? 🚀 |
all good got some help from the discord ! will commit a PR soon :) |
PR is here ! :) #24446 |
Hey @msftedad, thanks for reporting this issue! I believe it's incorrect to say that the keyboard focus is not visible. What happens is that you have focus on the element, which shows the outline, and once you press enter, the tests re-run and the panel re-renders. The focus is then lost, moved up to the top of the panel. I am not sure if that is a bad thing, because after you run the tests, you will likely want to go through the results, and not run the tests again. If you were to run the tests again, you probably would do so after making changes or interacting with the component, which will make you lose keyboard focus anyway. What do you think is the right approach here? |
Hi @yannbf, Thanks for the information. We will connect with the PO team and will get back to you soon. |
Thank you @msftedad, eager to hear back! |
Describe the bug
Keyboard focus is not visible While invoking the “Tests completed” button.
Actual Result:
Keyboard focus is not visible While invoking the “Tests completed” button.
Expected Result:
Keyboard focus should be visible While invoking the Tests completed” button.
To Reproduce
Attachments:
keyboard focus not visible tests completed.webm
System
Additional context
No response
The text was updated successfully, but these errors were encountered: