Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Keyboard focus is not visible While invoking the “Tests completed” button. #24129

Open
msftedad opened this issue Sep 11, 2023 · 8 comments

Comments

@msftedad
Copy link

Describe the bug

Keyboard focus is not visible While invoking the “Tests completed” button.

Actual Result:
Keyboard focus is not visible While invoking the “Tests completed” button.

Expected Result:
Keyboard focus should be visible While invoking the Tests completed” button.

To Reproduce

  1. Open URL: Common Navigation - Scrolling Panel ⋅ Storybook (windows.net)
  2. Navigate to “App bar” button at right side of the pane invoke it and navigate to “Default” link invoke it.
  3. Now navigate to "Accessibility" tab item invoke it and navigate "Tests completed" button invoke it observe the keyboard focus

Attachments:
keyboard focus not visible tests completed.webm

System

OS: Windows 11
OS version: 22H2 (OS Build 22621.2134)
Edge Version: 116.0.1938.69 (Official build) (64-bit)

Additional context

No response

@Nevnet99
Copy link
Contributor

Nevnet99 commented Oct 6, 2023

I can take a look at this 😊

@Nevnet99
Copy link
Contributor

Nevnet99 commented Oct 8, 2023

Having some trouble building up a sandbox with my local code for the a11y package can anyone point me in the right direction ? @shilman

@abhisheksharma010
Copy link

Hey there! 👋

I'm new to open source and super excited to dive in! I'd love to work on this. Can I be assigned to this issue? 🚀

@Nevnet99
Copy link
Contributor

Nevnet99 commented Oct 11, 2023

all good got some help from the discord ! will commit a PR soon :)

@Nevnet99
Copy link
Contributor

PR is here ! :) #24446

@yannbf
Copy link
Member

yannbf commented Oct 12, 2023

Hey @msftedad, thanks for reporting this issue! I believe it's incorrect to say that the keyboard focus is not visible. What happens is that you have focus on the element, which shows the outline, and once you press enter, the tests re-run and the panel re-renders. The focus is then lost, moved up to the top of the panel.

I am not sure if that is a bad thing, because after you run the tests, you will likely want to go through the results, and not run the tests again. If you were to run the tests again, you probably would do so after making changes or interacting with the component, which will make you lose keyboard focus anyway.

What do you think is the right approach here?

@msftedad
Copy link
Author

Hi @yannbf, Thanks for the information. We will connect with the PO team and will get back to you soon.

@yannbf
Copy link
Member

yannbf commented Nov 22, 2023

Thank you @msftedad, eager to hear back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants