Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Narrator is not announcing collapsed state for “Elements must only use allowed ARIA attributes drop down” in “Accessibility” pane. #24126

Open
msftedad opened this issue Sep 11, 2023 · 1 comment

Comments

@msftedad
Copy link

Describe the bug

Narrator is not announcing collapsed state for “Elements must only use allowed ARIA attributes drop down” in “Accessibility” pane.

Actual Result:
While navigating to the “Elements must only use allowed ARIA attributes” drop down in Accessibility pane narrator is not announcing the collapsed state of the drop down.

Expected Result:
While invoking the “Elements must only use allowed ARIA attributes drop down” in Accessibility pane narrator should announce the collapsed state of the drop down.

To Reproduce

  1. Open URL: Common Navigation - Scrolling Panel ⋅ Storybook (windows.net)
  2. Navigate to “App bar” button at right side of the pane invoke it and navigate to “Default” link invoke it.
  3. Now navigate to “Accessibility” tab item invoke it and navigate to “Elements must only use allowed ARIA attributes drop down” and observe the narrator announcement.

Attachments:
collapsed state .webm

System

OS: Windows 11
OS version: 22H2 (OS Build 22621.2134)
Edge Version: 116.0.1938.69 (Official build) (64-bit)

Additional context

No response

@Nevnet99
Copy link
Contributor

Nevnet99 commented Oct 11, 2023

I can take a look at this proposed solution would be to change the markup from a

with a role="button" so that we get the focus state without having to hack them onto a div although the tabIndex might get a bit wonky with this approach will try and get a PR up for this tomorrow 👍

This will also be quite a large change as I will need to add the same accessibility as:

  • Space: When the focus is on the Accordion Button of a collapsed section, expand the section.
  • Enter: When the focus is on an Accordion Button of a collapsed section, expand the section.
  • Tab: Moves focus to the next focusable element.
  • Shift-Tab: Moves focus to the previous focusable element.
  • Arrow down: Moves focus to the next Accordion Button.
  • Arrow up: Moves focus to the previous Accordion Button.
  • Home: When the focus is on an Accordion Button, move focus to the first Accordion Button.
  • End: When the focus is on an Accordion Button, move focus to the last Accordion Button.

This could also be debated to solve #24125 as then we have controls for the accordions via keyboard that will announce the label then focus the checkbox so imo we could combine the tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants