Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 7.1 Table of contents is not scrollable #23542

Closed
ajkl2533 opened this issue Jul 20, 2023 · 4 comments · Fixed by #23986
Closed

[Bug]: 7.1 Table of contents is not scrollable #23542

ajkl2533 opened this issue Jul 20, 2023 · 4 comments · Fixed by #23986

Comments

@ajkl2533
Copy link
Contributor

Describe the bug

When TOC became too long that overflows the viewport there is no way how to scroll to the lower items.

Screen.Recording.2023-07-20.at.16.31.00.mov

To Reproduce

  1. Enable TOC
  2. Open component docs (ideally with many stories)
  3. Make the viewport smaller so that TOC overflows

System

Environment Info:

  System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    Yarn: 3.5.0 - ~/.nvm/versions/node/v16.16.0/bin/yarn
    npm: 8.14.0 - ~/Projects/design-system-v2/node_modules/.bin/npm
  Browsers:
    Chrome: 114.0.5735.198
    Safari: 16.5.1
  npmPackages:
    @storybook/addon-a11y: ^7.1.0 => 7.1.0 
    @storybook/addon-actions: ^7.1.0 => 7.1.0 
    @storybook/addon-designs: ^7.0.1 => 7.0.1 
    @storybook/addon-docs: ^7.1.0 => 7.1.0 
    @storybook/addon-essentials: ^7.1.0 => 7.1.0 
    @storybook/addon-interactions: ^7.1.0 => 7.1.0 
    @storybook/blocks: ^7.1.0 => 7.1.0 
    @storybook/components: ^7.1.0 => 7.1.0 
    @storybook/jest: ^0.1.0 => 0.1.0 
    @storybook/react: ^7.1.0 => 7.1.0 
    @storybook/react-vite: ^7.1.0 => 7.1.0 
    @storybook/test-runner: ^0.11.0 => 0.11.0 
    @storybook/testing-library: ^0.2.0 => 0.2.0

Additional context

No response

@almoghaimo
Copy link
Contributor

almoghaimo commented Aug 2, 2023

Hello 👋

Can I work on this issue?
It's my first contribution, Is there any preferred way of solving this issue or any guidelines I should follow?

@vanessayuenn

@vanessayuenn
Copy link
Contributor

@shilman do you have any pointers for @almoghaimo?

@ghost
Copy link

ghost commented Aug 10, 2023

Hi @vanessayuenn, If no one is currently working on this I would like to work on this issue

@almoghaimo
Copy link
Contributor

Hi @vineetpradhan-dev I have already started to work on it.
I managed to reproduce the bug and pop up with a solution.

Are there any pointers about how to test it?
In addition, I'll add a video on what it looks like, can you tell if the scroll behavior is how it is expected to be?

fix_scroll_bug.mov

@vanessayuenn @shilman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants