Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storybook init: Angular project already installed #22342

Closed
Tracked by #22243
yannbf opened this issue May 2, 2023 · 2 comments · Fixed by #22392
Closed
Tracked by #22243

storybook init: Angular project already installed #22342

yannbf opened this issue May 2, 2023 · 2 comments · Fixed by #22392
Assignees
@valentinpalkovic
Labels
angular cli reported

Comments

@yannbf
Copy link
Member

yannbf commented May 2, 2023 •
edited
Loading

Error location: doInitiate

Suggested work:

See whether the implementation is correct (given that Angular with its multi-project nature behaves differently than any other Storybook framework). If the implementation is correct, we could change the behavior to provide a prompt in the CLI to the user to continue the installation if they wanted, rather than throwing an error and asking the user to run the command again.
@yannbf yannbf mentioned this issue May 2, 2023
Closed
@vanessayuenn vanessayuenn moved this to Ready for work in Core Team Projects May 2, 2023
@valentinpalkovic valentinpalkovic self-assigned this May 2, 2023
@valentinpalkovic valentinpalkovic moved this from Ready for work to In Progress in Core Team Projects May 4, 2023
@valentinpalkovic valentinpalkovic mentioned this issue May 4, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects May 11, 2023
@shilman
Copy link
Member

shilman commented May 11, 2023

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.16 containing PR #22392 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member

shilman commented May 12, 2023

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #22392 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
angular cli reported
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prompt to force initialization when storybook folder is detected storybookjs/storybook
3 participants
@shilman @yannbf @valentinpalkovic