Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom theme hover-color inconsistency #22199

Closed
artekkk opened this issue Apr 21, 2023 · 2 comments
Closed

[Bug]: Custom theme hover-color inconsistency #22199

artekkk opened this issue Apr 21, 2023 · 2 comments

Comments

@artekkk
Copy link

artekkk commented Apr 21, 2023

Describe the bug

I've created a custom theme and there is an inconsistency of hover-state coloring. In the bar a tint of the defined secondary color is used. In the main menu the hover color is a light blue color. Probably this is derived from the default theme. It would be nice if the hover state in the menu was handled the same way as in the bar.

image

To Reproduce

Create an custom theme with an alternative "colorSecondary".

System

Environment Info:

  System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 16.15.1 - C:\LProg\Ldev\node\node.EXE
    npm: 8.11.0 - C:\LProg\Ldev\node\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (112.0.1722.34)
  npmPackages:
    @storybook/addon-essentials: ^7.0.6 => 7.0.6
    @storybook/addon-interactions: ^7.0.6 => 7.0.6
    @storybook/addon-links: ^7.0.6 => 7.0.6
    @storybook/blocks: ^7.0.6 => 7.0.6
    @storybook/html: ^7.0.6 => 7.0.6
    @storybook/html-vite: ^7.0.6 => 7.0.6
    @storybook/manager-api: ^7.0.6 => 7.0.6
    @storybook/testing-library: ^0.0.14-next.2 => 0.0.14-next.2
    @storybook/theming: ^7.0.6 => 7.0.6

Additional context

No response

@artekkk artekkk changed the title [Bug]: Custom theme hover color inconsistency [Bug]: Custom theme hover-color inconsistency Apr 21, 2023
@yoshi2no
Copy link
Contributor

I'm currently working on this. If you would like, you can assign this issue to me. 🐶

@artekkk
Copy link
Author

artekkk commented May 30, 2023

Hi, it looks like the fix has been ready for merging for a long time. Is there a problem?

@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants