Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SB 7 Left/Right in TooltipLinkList are color 0.5 - should be 1.0 #21990

Closed
stevensacks opened this issue Apr 7, 2023 · 10 comments · Fixed by #22074
Closed

[Bug]: SB 7 Left/Right in TooltipLinkList are color 0.5 - should be 1.0 #21990

stevensacks opened this issue Apr 7, 2023 · 10 comments · Fixed by #22074

Comments

@stevensacks
Copy link
Contributor

Describe the bug

list-item has the following css:

color: rgba(201,205,207,0.5);

This is causing text/emojis in the left/right to be transparent.

Before (SB6):
before

Now (SB7):
after

To fix:

color: rgba(201,205,207);

To Reproduce

No response

System

No response

Additional context

No response

@shilman
Copy link
Member

shilman commented Apr 8, 2023

@MichaelArestad @valentinpalkovic I'm assuming this was an intentional change in 7.0, intended for text content. However it looks like a regression when the text is an emoji. Is there a better way to use an emoji as the left icon?

@MichaelArestad
Copy link
Contributor

@shilman This was not an intentional change. It was somehow missed.

The color for the left icons should be mediumdark. It should not be transparent.
The color for the list item text (resting) should be darkest. It should also not be transparent.
The color for the keyboard shortcut should be dark. It's background is the only transparent color and should be rgb(0 0 0 / 0.05).

@shilman shilman moved this to Nice to have in Core Team Projects Apr 11, 2023
@adityaKrModak
Copy link
Contributor

Please assign this issue to me.

@VinayChaurasiyaA
Copy link

assign me this!

@adityaKrModak
Copy link
Contributor

HI @valentinpalkovic @stevensacks
I have resolved the bug. Please review and let me know if any further adjustments are necessary.

@stevensacks
Copy link
Contributor Author

stevensacks commented Apr 13, 2023

@adityaKrModak What version is the fix included in? I'm on 7.0.4 and it's still transparent.

@adityaKrModak
Copy link
Contributor

adityaKrModak commented Apr 14, 2023

Kindly excuse for late reply.
I am on 7.1.0-alpha.3. i had tested the changes and added the screenshot in the PR, i will test in once again and confirm.

@adityaKrModak
Copy link
Contributor

I tested it on v7.0.4 too. its reflecting the changes

@github-project-automation github-project-automation bot moved this from Nice to have to Done in Core Team Projects May 8, 2023
@shilman
Copy link
Member

shilman commented May 9, 2023

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.14 containing PR #22074 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member

shilman commented May 9, 2023

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.10 containing PR #22074 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants