-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remark-slug
and remark-external-links
are deprecated
#21838
Comments
JReinhold
changed the title
Upgrade
Mar 30, 2023
remark-slug
and remark-external-links
are deprecatedremark-slug
and remark-external-links
are deprecated
Hi, this is my first time contributing, is it okay if I take up this issue? |
5 tasks
@JReinhold I have fixed the test cases, it would be extremely kind of you to take a look at this MR whenever its convenient. Dankjewel! |
I'm checking your PR @MehakFatima24 doing some tests. normally should work it is been legacy for 2 years now and they advice to switch to rehype |
5 tasks
vanessayuenn
moved this from In Progress
to Empathy - Ready for work
in Core Team Projects
Jan 15, 2024
8 tasks
github-project-automation
bot
moved this from Empathy - Ready for work
to Done
in Core Team Projects
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use two remark plugins to support our MDX functionality in
addon-docs
andbuilder-vite
:remark-slug
remark-external-links
Both of these plugins are marked as deprecated and the maintainer (who also maintains MDX) advices to switch to their rehype equivalent instead,
rehype-slug
andrehype-external-links
.If it doesn't produce any breaking changes, we should switch them over.
Additional context
remark-slug
is used to automaticall addid
to headings, which will create the link functionality to headings. That functionality should be preserved.remark-external-links
addstarget="_blank"
to all external links.The text was updated successfully, but these errors were encountered: