Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Searchbar does not reflect custom shortcut if set #21325

Closed
yannbf opened this issue Mar 1, 2023 · 5 comments
Closed

[Bug]: Searchbar does not reflect custom shortcut if set #21325

yannbf opened this issue Mar 1, 2023 · 5 comments

Comments

@yannbf
Copy link
Member

yannbf commented Mar 1, 2023

Describe the bug

Reported by @kbrandwijk (Thank you!)

If you override the ‘focus search’ shortcut, then the search field keeps showing the (now non-working) ‘/’ shortcut.

image

To Reproduce

System

No response

Additional context

No response

@kabhamo
Copy link

kabhamo commented Mar 9, 2023

@yannbf , @shilman,
Hi I hope you are doing well.
I am trying to fix the bug, but I need to console.log and debug some values.
I was trying to use the inspect=>console or source, but it dose not work.
Any suggestions, please?

@nv1327
Copy link

nv1327 commented Apr 3, 2023

@yannbf I would like to contribute to an open source project for a university class. Would you mind if I took up this issue?

@yannbf
Copy link
Member Author

yannbf commented Apr 21, 2023

Hey everyone so sorry for the late reply, but it seems like this issue is already being handled in a PR. Thank you so much for your interest <3

@shilman
Copy link
Member

shilman commented May 10, 2023

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.15 containing PR #21619 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@yannbf yannbf closed this as completed May 10, 2023
@github-project-automation github-project-automation bot moved this from Nice to have to Done in Core Team Projects May 10, 2023
@shilman
Copy link
Member

shilman commented May 12, 2023

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #21619 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants