We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The GFM automigration fails on a main.js that contains a complex addons config, such as the following:
main.js
addons
const postcssConfig = require('../postcss.config'); module.exports = { addons: [ { name: '@storybook/addon-postcss', options: { postcssLoaderOptions: { ...postcssConfig, implementation: require('postcss') } } },
It tries to parse the addons field into an array, append an addon string to the array, and then set it again in the ConfigFile object.
ConfigFile
https://github.com/inkline/inkline/blob/85c694daebf4eb18462988876d89ab95e4a0ab78/.storybook/main.js#L10-L18
No response
The text was updated successfully, but these errors were encountered:
I'll also note it claimed to work:
Sorry, something went wrong.
Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.6 containing PR #21731 that references this issue. Upgrade today to the @next NPM tag to try it out!
@next
npx sb@next upgrade --prerelease
shilman
Successfully merging a pull request may close this issue.
Describe the bug
The GFM automigration fails on a
main.js
that contains a complexaddons
config, such as the following:It tries to parse the
addons
field into an array, append an addon string to the array, and then set it again in theConfigFile
object.addons
and should append the string to the addons array in the AST to work around this issue.To Reproduce
https://github.com/inkline/inkline/blob/85c694daebf4eb18462988876d89ab95e4a0ab78/.storybook/main.js#L10-L18
System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: