[Bug]: v7: "global" module alias breaks package that uses the real "global" package

[Jack-Works]

Describe the bug

Storybook crashes with

ModuleNotFoundError: Module not found: Error: Can't resolve 'global/window' in 'xhr'

global is its own package, and is used by a package xhr.

storybook v7's default webpack config includes an alias which breaks the build.

To Reproduce

No response

System

Environment Info:

  System:
    OS: Windows 10
  Binaries:
    Node: 19.3.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.2.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.1325.0), Chromium (110.0.1587.50)
  npmPackages:
    @storybook/addon-actions: ^7.0.0-beta.53 => 7.0.0-beta.53
    @storybook/addon-essentials: ^7.0.0-beta.53 => 7.0.0-beta.53
    @storybook/addon-links: ^7.0.0-beta.53 => 7.0.0-beta.53
    @storybook/react: ^7.0.0-beta.53 => 7.0.0-beta.53
    @storybook/react-webpack5: ^7.0.0-beta.53 => 7.0.0-beta.53

Additional context

No response

[xylophonehero]

Temp fix by adding these lines to the webpackFinal function in the storybook main file

  webpackFinal: async (config) => {
    // Removing the global alias as it conflicts with the global npm pkg
    const { global, ...alias } = config.resolve.alias
    config.resolve.alias = alias
    
    // Other config
  }

https://storybook.js.org/docs/react/builders/webpack

[mallio]

I'm having this same issue within a storybook addon "@storybook/addon-console", which has a require('global/window') that webpack can't resolve. The workaround seems to fix it, but makes me question why storybook is aliasing a package that some of their own addons require to a different package.

[tmeasday]

@ndelangen ☝️ what's happening here?

[ndelangen]

👀

[ndelangen]

Yeah this is just a bug in 7.0, I'll remove the alias!

[shilman]

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.20 containing PR #22393 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

[shilman]

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.13 containing PR #22393 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade