Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: consider removing fs-extra #20228

Open
jimmywarting opened this issue Dec 13, 2022 · 7 comments
Open

[Feature Request]: consider removing fs-extra #20228

jimmywarting opened this issue Dec 13, 2022 · 7 comments

Comments

@jimmywarting
Copy link

Is your feature request related to a problem? Please describe

most of the things you use already exist in node:fs and node:fs/promises

Describe the solution you'd like

would be nice to depend on fewer dependencies

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

@kasperpeulen
Copy link
Contributor

Are those libraries available for Node 16? @jimmywarting

@ndelangen
Copy link
Member

@jimmywarting if we can use node:fs/promises everywhere, that seems nice to me.

Mind you, we have a bunch of places with tests where we mock out fs-extra.
Would you be able to open a PR migrating us to node:fs/promises?

@ndelangen
Copy link
Member

I labelled this "good first issue". Someone with NodeJS experience maybe be able to pick this up.
Work is likely not too complex, but I do expect a bunch of failures in for example tests.

Getting a PR open migrating the monorepo from using fs-extra to node:fs/promises would help!

@Arav1nd2
Copy link

Arav1nd2 commented Feb 3, 2023

Hey @ndelangen Can I work on this feature?

@kasperpeulen
Copy link
Contributor

@Arav1nd2 Would be really appreciated!

@Arav1nd2
Copy link

Arav1nd2 commented Feb 5, 2023

Cool thanks! Whom / where can I reach out to in case I have doubts?

@yannbf
Copy link
Member

yannbf commented Feb 5, 2023

@Arav1nd2 reach out on our discord channel, we have a contributing channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants