-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automigration MDX1 HTML comments to MDX2 JSX comments #20200
Comments
@shilman replacing HTML-comment with JS comments in all MDX files, should do the trick right? We likely will have to do this with a RegExp, considering the MDX compiler actually is not able to parse the file..
This seems like the best place for it:
|
Yup!! |
Docusaurus maintainer 👋 also trying to upgrade to MDX 2 facebook/docusaurus#8288 Worth taking into consideration that comments might be nested inside HTML code blocks 🤪 <!-- md comment -->
```html
<div>
<!-- HTML comment (do not transform) -->
</div>
```
|
Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.26 containing PR #20349 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
See #18554
The text was updated successfully, but these errors were encountered: