Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow opt-in MDX1 support in SB7 to ease migration #20145

Closed
Tracked by #20674
shilman opened this issue Dec 8, 2022 · 1 comment
Closed
Tracked by #20674

Allow opt-in MDX1 support in SB7 to ease migration #20145

shilman opened this issue Dec 8, 2022 · 1 comment
Assignees
@shilman
Labels
feature request mdx

Comments

@shilman
Copy link
Member

shilman commented Dec 8, 2022 •
edited
Loading

MDX2 is the new default in SB7. Unfortunately, it contains lots of breaking changes relative to MDX1 and the migration is a lot of work.

Nevertheless, It is an important upgrade. Not only is MDX2 much better, but MDX1 contains security audit violations that we can't ship with SB7.

However, we could allow users to opt-in to MDX1 to ease their transition to SB7. We could do this similar to how we had users opt in to MDX2 using a feature flag in v6.5.
@shilman shilman converted this from a draft issue Dec 8, 2022
@shilman shilman moved this to Nice to have in Core Team Projects Dec 8, 2022
@shilman shilman moved this from Nice to have to Must have for beta in Core Team Projects Dec 12, 2022
@shilman shilman self-assigned this Dec 12, 2022
@shilman shilman moved this from Required for beta announcement to Required for RC in Core Team Projects Dec 15, 2022
@shilman shilman changed the title Idea: Allow opt-in MDX1 support in SB7 to ease migration Allow opt-in MDX1 support in SB7 to ease migration Jan 10, 2023
@vanessayuenn vanessayuenn mentioned this issue Jan 18, 2023
Closed
3 tasks
@shilman shilman moved this from Required for RC to In Progress in Core Team Projects Jan 20, 2023
This was referenced Jan 23, 2023
Merged
Merged
@shilman
Copy link
Member Author

shilman commented Jan 25, 2023

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.34 containing PR #20747 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Jan 25, 2023
@vanessayuenn vanessayuenn mentioned this issue Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
feature request mdx
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman