Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons tab still shows in mobile viewports even when showPanel:false is set #18386

Closed
TristanWatanabe opened this issue Jun 1, 2022 · 4 comments
Labels

Comments

@TristanWatanabe
Copy link

Describe the bug

When setting showPanel: false in the manager.js file, the add-ons panel is hidden on desktop viewports but is still present in mobile viewports. My expectation here would be that when showPanel: false is set, the addons tab is completely inaccessible whether it be on desktop or mobile.

To Reproduce

Repro Repo: https://github.com/TristanWatanabe/storybook-issue-repro
Published Chromatic Link: https://62979a5749b36f003aba9679-uzhortlcyh.chromatic.com/?path=/story/example-button--primary

Steps to Repro:

  1. Open chromatic link .
  2. Open chrome console.
  3. Click on "Toggle Device Emulation" and observe issue.
    • image

System

System:
OS: Linux 5.10 Ubuntu 20.04.2 LTS (Focal Fossa)
CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
Binaries:
Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
Yarn: 3.2.1 - /usr/bin/yarn
npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
Browsers:
Chrome: 93.0.4577.63
npmPackages:
@storybook/addon-a11y: ^6.5.6 => 6.5.6
@storybook/addon-actions: ^6.5.6 => 6.5.6
@storybook/addon-docs: ^6.5.6 => 6.5.6
@storybook/addon-essentials: ^6.5.6 => 6.5.6
@storybook/addon-interactions: ^6.5.6 => 6.5.6
@storybook/addon-knobs: ^6.4.0 => 6.4.0
@storybook/addon-links: ^6.5.6 => 6.5.6
@storybook/addons: ^6.5.6 => 6.5.6
@storybook/builder-webpack5: ^6.5.6 => 6.5.6
@storybook/manager-webpack5: ^6.5.6 => 6.5.6
@storybook/node-logger: ^6.5.6 => 6.5.6
@storybook/preset-create-react-app: ^4.1.2 => 4.1.2
@storybook/react: ^6.5.6 => 6.5.6
@storybook/testing-library: ^0.0.11 => 0.0.11

@BikashSah999
Copy link
Contributor

Hi @shilman @ndelangen @tmeasday , Can I work on this issue ?

@shilman shilman added ui and removed needs triage labels Nov 10, 2022 — with Volta.net
Copy link
Member

shilman commented Nov 10, 2022

@BikashSah999 That would be awesome!!! 🙏

@BikashSah999
Copy link
Contributor

BikashSah999 commented Nov 14, 2022

Hi @shilman @ndelangen @tmeasday @JReinhold , the PR for this issue is up for review. Could you please review it?

@shilman
Copy link
Member

shilman commented Nov 19, 2022

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.51 containing PR #19807 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants