Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/react-native is not installed when using getstorybook #1738

Closed
mymachine8 opened this issue Aug 25, 2017 · 5 comments
Closed

@storybook/react-native is not installed when using getstorybook #1738

mymachine8 opened this issue Aug 25, 2017 · 5 comments

Comments

@mymachine8
Copy link

I followed the below steps,

  1. npm -g i @storybook/cli
  2. went to the project directory and ran getstorybook
  3. now when I try to do, npm run storybook it is throwing me an error

storybook start -p 7007
sh: storybook: command not found

version:
screen shot 2017-08-25 at 5 08 49 pm
storybook/[email protected]

@danielduan
Copy link
Member

danielduan commented Aug 25, 2017

try using yarn run storybook.

My guess is, you're probably running an older npm version. depending on how old it is, it might not support executing a bin from the local node_modules install.

Either that, or it might not have been installed properly

@mymachine8
Copy link
Author

manually installing, npm install --save @storybook/react-native fixed my issue. Some how this library is not added in my package.json when I ran getstorybook

@danielduan
Copy link
Member

danielduan commented Aug 25, 2017

Think this is a bug. Looks like @storybook/react-native isn't added during getstorybook.

https://github.com/storybooks/storybook/blame/master/lib/cli/generators/REACT_NATIVE/index.js#L36

@ndelangen
Copy link
Member

ndelangen commented Aug 25, 2017

@mymachine8 Do you think you could open a PR to fix this?
It would help a lot of people out actually!

@danielduan danielduan changed the title Unable to get storybook running for my react-native app @storybook/react-native is not installed when using getstorybook Aug 26, 2017
@shilman
Copy link
Member

shilman commented Aug 26, 2017

I fixed this and released it in v3.2.9. Sorry for the hassle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants