Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated peer deps when using react 17 #16799

Closed
jasonwilliams opened this issue Nov 26, 2021 · 3 comments
Closed

outdated peer deps when using react 17 #16799

jasonwilliams opened this issue Nov 26, 2021 · 3 comments

Comments

@jasonwilliams
Copy link

jasonwilliams commented Nov 26, 2021

Describe the bug
@storybook/theming has a dependency on @emotion/core, which only supports react ^16.3.0 as a peer dependency.

Is it possible to update emotion/core or use something else as it seems emotion/core no longer exists? https://www.npmjs.com/package/@emotion/core

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"17.0.2" from the root project
npm ERR!   peer react@">=16.3.0" from @emotion/[email protected]
npm ERR!   node_modules/@emotion/core
npm ERR!     peer @emotion/core@"^10.0.27" from @emotion/[email protected]
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^10.0.27" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/theming
npm ERR!         @storybook/theming@"6.3.12" from @storybook/[email protected]
npm ERR!         node_modules/@storybook/addon-actions
npm ERR!         15 more (@storybook/addon-backgrounds, ...)
npm ERR!     peer @emotion/core@"^10.0.28" from @emotion/[email protected]
npm ERR!     node_modules/@emotion/styled-base
npm ERR!       @emotion/styled-base@"^10.0.27" from @emotion/[email protected]
npm ERR!       node_modules/@emotion/styled
npm ERR!         @emotion/styled@"^10.0.27" from @storybook/[email protected]
npm ERR!         node_modules/@storybook/theming
npm ERR!     3 more (@storybook/theming, @storybook/ui, emotion-theming)
npm ERR!   55 more (@emotion/styled, @emotion/styled-base, @mdx-js/react, ...)

There's a similar issue here:

npm ERR! Could not resolve dependency:
npm ERR! peer react@"15.x || 16.x || 16.4.0-alpha.0911da3" from @reach/[email protected]
npm ERR! node_modules/@reach/router
npm ERR!   @reach/router@"^1.3.4" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/api
npm ERR!     @storybook/api@"6.3.12" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/addon-actions
npm ERR!       @storybook/addon-actions@"6.3.12" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/addon-essentials
npm ERR!       1 more (web)
npm ERR!     13 more (@storybook/addon-backgrounds, ...)
npm ERR!   @reach/router@"^1.3.4" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/router
npm ERR!     @storybook/router@"6.3.12" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/addon-links
npm ERR!       dev @storybook/addon-links@"^6.3.12" from [email protected]
npm ERR!       web
npm ERR!     5 more (@storybook/addons, @storybook/api, ...)

Another dependency issues is here:

npm WARN deprecated [email protected]: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added

which comes from addon-docs not using jest/transform v27

@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jan 9, 2022
@jasonwilliams
Copy link
Author

not stale

@stale stale bot removed the inactive label Jan 9, 2022
@shilman
Copy link
Member

shilman commented Jan 10, 2022

Hi Jason, We've updated Storybook to use react-router to solve the second issue. The first issue is a duplicate to #13145, closing this for now.

@shilman shilman closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants