Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make storybooks more impartial #1654

Closed
miljan-aleksic opened this issue Aug 14, 2017 · 3 comments
Closed

Make storybooks more impartial #1654

miljan-aleksic opened this issue Aug 14, 2017 · 3 comments

Comments

@miljan-aleksic
Copy link

I love the initiative to support other frameworks, and in that line of work, I would like to see less about react/vue and more about the storybooks as a whole. For example:

  • The repo description is about React, only.
  • The storybooks source code, even if react based, should not have react namespaces in the result. There are data named as data-reactroot which when using Vue lead to believe you are using the wrong version.
  • The docs and site are about React 99%, even the Vue part is referencing at some point react instead of Vue.
  • FW specific addons should be moved to a different section.

I am sure you are aware of this and working toward a transition, which takes time, but seems there are some easy task that could be done already. Like updating the repo description and docs.

I can definitely help about this if required.

@Hypnosphi
Copy link
Member

There are data named as data-reactroot which when using Vue lead to believe you are using the wrong version.

Can you please elaborate? data-reactroot is attached and used by React DOM, not by Storybook app itself.

Anyway, feel free to contribute!

@miljan-aleksic
Copy link
Author

Ok, I don't know react works, we can skip that one :)

@ndelangen
Copy link
Member

Definitely something we're working on. It's a continues process of improving the codebase.

I think for the most part the points made in the OP have been addressed, If you have specific places you can point us to to improve: please let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants