Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storyshots: decorators are part of the snapshots #1620

Closed
testerez opened this issue Aug 8, 2017 · 6 comments
Closed

storyshots: decorators are part of the snapshots #1620

testerez opened this issue Aug 8, 2017 · 6 comments

Comments

@testerez
Copy link
Contributor

testerez commented Aug 8, 2017

When testing with storyshots, the decorators added with addDecorator are repeated in every snapshots. It would be great if the snapshots contain only the stories.
Is there any way to do it?

@coreylight
Copy link

I have a branch intended to fix this, but Github is crashing every time I try to make a PR 😕
https://github.com/coreylight/storybook/tree/no-decorators-in-storyshots

@usulpro
Copy link
Member

usulpro commented Sep 15, 2017

@coreylight Did you try to update your fork?
If still no success I can create a branch in storybook repo

@coreylight
Copy link

@usulpro How should I update it? It looks like the diff is just massive. I based the branch on release/3.3 due to this particular functionality being affected by wanting to use a snapshot per story, and not 1 big snapshot.

@usulpro
Copy link
Member

usulpro commented Sep 15, 2017

@coreylight is it #1849?
Could you add a description to this PR or close it if something wrong?

@stale
Copy link

stale bot commented Nov 2, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. We do try to do some housekeeping every once in a while so inactive issues will get closed after 90 days. Thanks!

@stale stale bot added the inactive label Nov 2, 2017
@stale
Copy link

stale bot commented Nov 17, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants