Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree animations perform poorly when knobs are present #1606

Closed
Hypnosphi opened this issue Aug 6, 2017 · 8 comments
Closed

Tree animations perform poorly when knobs are present #1606

Hypnosphi opened this issue Aug 6, 2017 · 8 comments

Comments

@Hypnosphi
Copy link
Member

Hypnosphi commented Aug 6, 2017

It's easy to reproduce if you move the 'with knobs' story on the top of the 'Button' group in examples/cra-kitchen-sink/src/stories/index.js:

gif

I'm not really sure, should we fix it on the side of knobs, tree, or both

@kohlmannj
Copy link
Contributor

kohlmannj commented Aug 24, 2017

Adding a written "+1":

We're seeing unusable levels of sluggishness in a large Storybook (~30 components, 40+ stories), with multiple stories that use knobs, after upgrading to v3.2.x. It's bad enough that I reverted back to the v3.1.x versions of @storybook/react and related dependencies.

I will attempt to investigate and further diagnose the underlying cause as time permits.

@ratheo
Copy link

ratheo commented Oct 3, 2017

We're also seeing very slow rendering. Especially the encoding and decoding of knobs for the url is taking up a lot of time. It would be nice if it could be disabled.

@igor-dv
Copy link
Member

igor-dv commented Oct 3, 2017

You can change the sidebarAnimations to false with the options-addon. It will disable the tree animations.

https://github.com/storybooks/storybook/tree/master/addons/options

@stale
Copy link

stale bot commented Nov 17, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 17, 2017
@Hypnosphi
Copy link
Member Author

In my case, removing global withKnobs decorator helped a lot

@stale
Copy link

stale bot commented Jan 1, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale
Copy link

stale bot commented Jan 16, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jan 16, 2018
@mrlubos
Copy link

mrlubos commented Mar 2, 2018

Did anyone else experience delayed knob state updates? Let's say I have a text knob and as I type, every 2 or 3 characters it will backtrack by 1. Makes it very frustrating to use. I am only trying to determine if this is because of knobs right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants