Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix main.ts regression #14095

Closed
shilman opened this issue Mar 2, 2021 · 3 comments
Closed

Core: Fix main.ts regression #14095

shilman opened this issue Mar 2, 2021 · 3 comments
Assignees
@shilman
Labels
bug builder-webpack5 core
Milestone
6.2 blocking

Comments

@shilman
Copy link
Member

shilman commented Mar 2, 2021 •
edited by sync-by-unito bot
Loading

Main.ts support regressed in #13808 h/t yannbf

I guess now that core was split into two, the babel/register was removed as dep and not moved to the packages. Having that dependency is basically what adds support for .ts files.

(See #11763 for the last time it regressed

┆Issue is synchronized with this Asana task by Unito
@shilman shilman added this to the 6.2 blocking milestone Mar 2, 2021
@shilman shilman self-assigned this Mar 2, 2021
@shilman shilman mentioned this issue Mar 4, 2021
Merged
@shilman
Copy link
Member Author

shilman commented Mar 4, 2021

Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-beta.9 containing PR #14123 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 4, 2021
@shilman shilman reopened this Mar 9, 2021
@shilman
Copy link
Member Author

shilman commented Mar 9, 2021

Still seeing this issue in a CRA app. Needs more investigation...

@shilman shilman mentioned this issue Mar 9, 2021
Merged
@shilman
Copy link
Member Author

shilman commented Mar 10, 2021

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-beta.13 containing PR #14184 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
bug builder-webpack5 core
Projects
None yet
Milestone
6.2 blocking
Development

No branches or pull requests
1 participant
@shilman