Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing for examples-v2-yarn-2 #12984

Closed
shilman opened this issue Nov 2, 2020 · 2 comments
Closed

Build failing for examples-v2-yarn-2 #12984

shilman opened this issue Nov 2, 2020 · 2 comments
Assignees
Labels
maintenance User-facing maintenance tasks

Comments

@shilman
Copy link
Member

shilman commented Nov 2, 2020

I believe our heuristic for the React JSX transform is failing:

https://github.com/storybookjs/storybook/blob/next/app/react/src/server/framework-preset-react.ts#L25-L29

=>

https://app.circleci.com/pipelines/github/storybookjs/storybook/14433/workflows/b9c53217-9b45-481e-a5d0-8576d5e1c583/jobs/272315

Success! Created cra-latest at /tmp/storybook-e2e-testing/cra-latest
...
👷 Building Storybook
...

ERR! src/App.js
ERR!   Line 6:5:    'React' must be in scope when using JSX  react/react-in-jsx-scope
ERR!   Line 7:7:    'React' must be in scope when using JSX  react/react-in-jsx-scope
ERR!   Line 8:9:    'React' must be in scope when using JSX  react/react-in-jsx-scope
ERR!   Line 9:9:    'React' must be in scope when using JSX  react/react-in-jsx-scope
ERR!   Line 10:16:  'React' must be in scope when using JSX  react/react-in-jsx-scope
ERR!   Line 12:9:   'React' must be in scope when using JSX  react/react-in-jsx-scope

Tho shouldn't this be using CRA's preset?

@shilman shilman added the maintenance User-facing maintenance tasks label Nov 2, 2020
@gaetanmaisse
Copy link
Member

Somehow related to #12928, maybe a duplicate, to investigate

@shilman
Copy link
Member Author

shilman commented Nov 4, 2020

Seems to have gone away with #12972. Closing.

@shilman shilman closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants