Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Intro MDX loses global styling in React 17 #12879

Closed
shilman opened this issue Oct 23, 2020 · 1 comment
Closed

CLI: Intro MDX loses global styling in React 17 #12879

shilman opened this issue Oct 23, 2020 · 1 comment
Labels
bug cli mdx

Comments

@shilman
Copy link
Member

shilman commented Oct 23, 2020

Introduction.stories.mdx generated by the CLI template is missing fonts and some other styling when upgraded to React 17:

Example___Introduction_-_Page_⋅_Storybook

What's going on here is that MDX uses JSX pragmas under the hood and Emotion 10 is not yet compatible with React 17 when it comes to pragmas: emotion-js/emotion#2041

Hopefully we can upgrade once a fix is out and that will fix the problem!
@shilman
Copy link
Member Author

shilman commented Nov 13, 2020

Fixed in https://github.com/storybookjs/storybook/releases/tag/v6.1.0-rc.2 closing

@shilman shilman closed this as completed Nov 13, 2020
@shilman shilman mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli mdx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman