Keyboard shortcuts on non-english keyboards

[kevinsimper]

Describe the bug
If you use a non-english keyboards, the keyboard shortcuts does not work, for example "/".

To Reproduce
I wrote a blogpost about it as it is a common a11y problem for non-native english programmers.
https://medium.com/@kevinsimper/why-keyboard-shortcuts-and-accessibility-in-other-keyboard-languages-rarely-works-8638abc15e71

How to solve
The reason is that a keycode integer is used instead of a key string to compare what was pressed.

[Tomastomaslol]

Hi @kevinsimper!

Thanks for sharing your article! I wasn't aware of this issue so this will help me to build better applications in future! :)

Would you like to try and solve it? Otherwise, I would be happy to fix this

[kevinsimper]

@Tomastomaslol Thank you 👍

Looking at the code I found something in UI, but the README also needs a update:
https://github.com/storybookjs/storybook/blob/next/lib/ui/README.md#keyboard-shortcuts as src/modules/ui/configs/handle_routing.js does not exist inside ui anymore.

So the keyboard shortcuts are here:

storybook/lib/api/src/modules/shortcuts.ts

Line 61 in 00628f8

search: ['/'],

And it looks to be that the bug is looks if shiftKey is pressed down, which it is on non-english keyboards, but the shortcut does not specify it:

storybook/lib/api/src/lib/shortcut.ts

Line 33 in 00628f8

if (e.shiftKey) {

[kevinsimper]

@tmeasday I can see you have worked in the shortcuts for storybook, that is super awesome! 👍 😄 Do you have an idea on how to solve this? What would be the approach?

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[tmeasday]

Hi @kevinsimper sorry for the slow response I thought I had written something earlier but it seems to have been lost into the matrix..

I haven't worked on this code in quite a while so I would be pretty much figuring out it from first principles too ;) What I do know is the code is pretty contained to the setting page that sets them and the "module" that provides the API

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[kainbacher]

+1 for this issue

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[ghengeveld]

This should be addressed in #13319

Let me know if this needs more work.