-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @storybook/preact to support Preact 10 #10973
Labels
Comments
@fjorgemota would you mind submitting a PR with that one-line change? |
Closed by #10978. |
Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.21 containing PR #10978 that references this issue. Upgrade today to try it out! You can find this prerelease on the |
Nice! Thanks! |
This was referenced Dec 15, 2021
This was referenced Jun 2, 2022
This was referenced Sep 25, 2023
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Preact 10 is already a few months old, but, at least according to
@storybook/preact
'speerDependencies
, it's not supported by Storybook yet. However, that module seems to work fine with latest Preact 10...Describe the solution you'd like
Check if Preact 10 definitely works fine with
@storybook/preact
and update peerDependencies to reflect that.Are you able to assist bring the feature to reality?
Assuming that the test suite already covers
@storybook/preact
successfully, I think I can try to update the peerDependencies requirement and verify if everything still works fine.Additional questions
Do we will still support Preact 8? Or just support Preact 10 from now on? Again, according to my experience, Preact 10 works just fine with Storybook..and according to what I saw Storybook doesn't use too much from Preact too, so I think that this compatibility could be preserved for more time without problems.
The text was updated successfully, but these errors were encountered: