CLI: check for missing/unneeded deps when initializing SB in a project

[gaetanmaisse]

Work summary

When using CLI to initialize Storybook in a project some dependencies are added (according to the framework) to have everything working out of the box. For instance, for a CRA project the following dependencies are added:

• @storybook/react
• @storybook/preset-create-react-app
• @storybook/addon-actions
• @storybook/addon-links
• @storybook/addons

To offer the best UX, make a good impression and so improve Storybook adoption we need to be sure that all added dependencies are necessary and that there is no missing dependency or peer dependency.

This work is part of #10723

Where to start

🔍 Run E2E tests locally and check all dependency warnings returned by NPM or Yarn.

➕ Add the dependencies that are reported as missing by the package manager OR the origin of this warning and make sure that this is not due to missing or unneeded dependencies in @storybook packages.

🗑️ Remove potentially unneeded dependencies and check that everything is still ok (for instance, @storybook/addons looks to be a dependency of each addon so no need to add it one more time via the project dependencies)

Note: Yarn 2 can help with that because it is way more strict on missing dependencies than NPM or Yarn 1.

Acceptance criteria

• E2E tests are passing
• Changes are properly reviewed by some of the members mentioned below
• 🤷 Not sure how we can test that we are only adding needed dependencies

Who to contact

@gaetanmaisse @ndelangen @tooppaaa @yannbf

[gaetanmaisse]

Don't worry stale we will do it ;)

[gaetanmaisse]

I will work on it after #10797

[shilman]

Related (but different): #11396

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[yannbf]

Hey @gaetanmaisse, shall we check about the state of this again, given that quite some things changed and the addons that come via the CLI templates are now a bit different?

[gaetanmaisse]

🤔 True! We should take a deep look at all packages' deps and devDeps but it's not directly related to the CLI anymore.