Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: remove addon notes from framework generators #10796

Closed
2 tasks
yannbf opened this issue May 15, 2020 · 3 comments
Closed
2 tasks

CLI: remove addon notes from framework generators #10796

yannbf opened this issue May 15, 2020 · 3 comments
Assignees
@yannbf
Labels
cli maintenance User-facing maintenance tasks
Milestone
6.1 essentials

Comments

@yannbf
Copy link
Member

yannbf commented May 15, 2020

Work summary

We have have to remove the usage of addon notes in the boilerplate generated from the CLI.
The reason is that the addon is removed starting from Storybook 6 in favor of addon docs.

This work is part of #10723

Where to start

There are stories in the generators folder which contain the notes parameter like this one.
All stories using notes:
image

Acceptance criteria

  • E2E tests are passing
  • Changes are properly reviewed by some of the members mentioned below

Who to contact

@yannbf @tooppaaa @ndelangen @gaetanmaisse
@yannbf yannbf added maintenance User-facing maintenance tasks cli labels May 15, 2020
@yannbf yannbf mentioned this issue May 15, 2020
Closed
2 tasks
@shilman shilman added this to the 6.0 essentials milestone May 19, 2020
@stale stale bot added the inactive label Jun 9, 2020
@tooppaaa tooppaaa removed the inactive label Jun 9, 2020
@yannbf
Copy link
Member Author

yannbf commented Jun 9, 2020 via email •
edited
Loading

@storybookjs storybookjs deleted a comment from stale bot Jun 10, 2020
@yannbf
Copy link
Member Author

yannbf commented Jul 4, 2020

I'm taking this!

@yannbf yannbf mentioned this issue Jul 12, 2020
Closed
@yannbf
Copy link
Member Author

yannbf commented Aug 20, 2020

Closing this as the work will be done when #12173 is addressed.

@yannbf yannbf closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannbf yannbf

Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.1 essentials
Development

No branches or pull requests
3 participants
@shilman @tooppaaa @yannbf