Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hooks in storyshots #10483

Closed
brandon-leapyear opened this issue Apr 20, 2020 · 1 comment
Closed

Support hooks in storyshots #10483

brandon-leapyear opened this issue Apr 20, 2020 · 1 comment

Comments

@brandon-leapyear
Copy link
Contributor

Is your feature request related to a problem? Please describe.
#8177

This PR added support for hooks in stories: #7571, but storyshots still breaks, even though the story works.

Describe the solution you'd like

Describe alternatives you've considered
There are many workarounds in the linked issue, but since storybook now supports hooks, i expect storyshots to have the same built-in support.

Are you able to assist bring the feature to reality?
yes, i can make a PR

Additional context

@shilman
Copy link
Member

shilman commented Apr 27, 2020

Released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.43 which references this issue in #10529 . Closing this!

@shilman shilman closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants