Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icon in the tree #10379

Open
thany opened this issue Apr 10, 2020 · 6 comments
Open

Custom icon in the tree #10379

thany opened this issue Apr 10, 2020 · 6 comments

Comments

@thany
Copy link

thany commented Apr 10, 2020

Is your feature request related to a problem? Please describe.
I'm making a MDX docs-only story that will act as the homepage of our Storybook instance, and it would be nice to give that item a homepage-worthy icon in the tree.

Describe the solution you'd like
Perhaps in the <Meta> MDX element, add a prop that accepts an SVG path and a colour, that will be passed on to the tree.

Describe alternatives you've considered
I don't think a workaround is possible, because icons are hardcoded in ListItem.tsx.
I've tried to add an emoji into the title of a story, but that doesn't look quite right.

Are you able to assist bring the feature to reality?
Maybe. Depends on the solution we're heading for, should this feature request be approved.

Additional context
Not just homepages, you know. It might be helpful to easily distinguish different component by different icons, or different colours of icons.

@stale
Copy link

stale bot commented May 2, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 2, 2020
@stale
Copy link

stale bot commented Jun 2, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jun 2, 2020
@masterbd
Copy link

Can we reopen this issue?

@shilman shilman reopened this Dec 16, 2020
@stale stale bot removed the inactive label Dec 16, 2020
@shilman
Copy link
Member

shilman commented Dec 16, 2020

Cc @tooppaaa @ghengeveld @domyen

@tooppaaa
Copy link
Contributor

Would this solves your request ?
#13121

@thany
Copy link
Author

thany commented Dec 17, 2020

@tooppaaa Looks alright. A slightly different thing than what I imagined, but it would do the job (when approved).
Too bad that PR introduces several things at once, and "prefix" is not the term I would use personally.

@shilman shilman added this to the 8.x theming milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants