Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant core-js and airbnb-js-shims deps #10206

Closed
f-masche opened this issue Mar 24, 2020 · 9 comments
Closed

Redundant core-js and airbnb-js-shims deps #10206

f-masche opened this issue Mar 24, 2020 · 9 comments

Comments

@f-masche
Copy link

f-masche commented Mar 24, 2020

Is your feature request related to a problem? Please describe.

I recently started using storybook for an angular project, and I noticed the bundle size is HUGE (vendor bundle is about 7.8 MB !!!) and the startup times are not the greatest.

Question: Is there any effort taken on improving performance and reducing the bundle size in the future?

During my research, I found some redundant dependencies like core-js and airbnb-js-shims in storybook/core, which kind of do the same thing 🤷‍♂️.
Is there a reason for having both lowlight and refactor for syntax highlighting, including ALL language files?

Describe the solution you'd like

  1. Remove either core-js or airbnb-js-shims.
  2. Choose between lowlight and refactor and load only js and css languages.

Describe alternatives you've considered
None so far.

Are you able to assist bring the feature to reality?
Yes I could definitelly do some work.

@shilman
Copy link
Member

shilman commented Mar 25, 2020

@f-masche This would be a tremendous contribution to Storybook and we'd love help on this. I'm hoping to do a full performance release post 6.0 but in the meantime all perf-related contributions are welcome.

In general, I suspect there's a lot of low-hanging fruit here. Renaming this issue to be more specific, but please feel free to open more issues/PRs as needed. Also you can filter issues by the performance issue label:

https://github.com/storybookjs/storybook/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22performance+issue%22

@shilman shilman changed the title Redundant dependencies Redundant core-js and airbnb-js-shims dependencies Mar 25, 2020
@shilman shilman changed the title Redundant core-js and airbnb-js-shims dependencies Redundant core-js and airbnb-js-shims deps Mar 25, 2020
@ndelangen
Copy link
Member

@f-masche want to talk in a zoom call about this some time?

Feel free to take a slot in my calendar:
https://calendly.com/ndelangen/storybook

@stale
Copy link

stale bot commented Apr 17, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 17, 2020
@stale
Copy link

stale bot commented May 17, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed May 17, 2020
@shilman shilman reopened this Nov 10, 2020
@stale stale bot removed the inactive label Nov 10, 2020
@shilman shilman added this to the 6.1 perf milestone Nov 10, 2020
@shilman
Copy link
Member

shilman commented Nov 10, 2020

Current bundle:

  • core-js 249kb
  • es6-shim 136kb
  • es5-shim 107kb
  • es-abstract 54kb
  • regenerator-runtime 24kb

@shilman shilman modified the milestones: 6.1 perf, 6.2 perf Nov 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@Semigradsky
Copy link

Semigradsky commented Apr 20, 2022

Hi! How to remove es5-shim from the storybook?

I currently have an issue with Date on Safari 15.3:

> new Date('1900-01-01T00:00:00.000')
< Invalid Date

It fails MUI's CalendarPicker.


UPD: It looks similar to #400


UPD2: Currently I "fixing" it by ignoring airbnb-js-shims via adding yarn resolution to my package.json:

  "resolutions": {
    "airbnb-js-shims": "npm:@favware/[email protected]"
  },

@stale stale bot removed the inactive label Apr 20, 2022
@ndelangen
Copy link
Member

ndelangen commented Jun 28, 2022

This is complete in future/base, which is the main branch for 7.0. So this is on the way!

@shilman
Copy link
Member

shilman commented Dec 14, 2022

closing as fixed in 7.0

@shilman shilman closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants