-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lib/api] Move @types/reach__router into devDependencies? #10091
Comments
We re-export some types from reach-router. If we move them, our packages break for typescript users, because the typings we refer to would be missing. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Is your feature request related to a problem? Please describe.
I'm using Storybook with non-React JSX factory.
Since
@storybook/api
depends on@types/reach__router
and it also brings@types/react
, which introduces a global pollution ofJSX
namespace (declare global { namespace JSX { ... } }
).Describe the solution you'd like
Moving
@types/reach__router
fromdependencies
todevDependencies
looks fine for me.(Or is there a fair reason to declare it as a runtime dependency?)
storybook/lib/api/package.json
Line 37 in 1af0458
Describe alternatives you've considered
Nothing.
Are you able to assist bring the feature to reality?
Yes.
If this change looks fine, I'm glad to open a pull request.
Additional context
Other
@types/*
packages are defined indevDependencies
.storybook/lib/api/package.json
Lines 51 to 53 in 1af0458
The text was updated successfully, but these errors were encountered: