Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Output directory in config #512

Closed
1 task
jgunzelman88 opened this issue Oct 14, 2022 · 1 comment
Closed
1 task

[Bug] Output directory in config #512

jgunzelman88 opened this issue Oct 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jgunzelman88
Copy link

What version of vite are you using?

0.2.4

System info and storybook versions

Environment Info:

System:
OS: macOS 12.6
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Binaries:
Node: 16.17.0 - /usr/local/opt/node@16/bin/node
npm: 8.15.0 - /usr/local/opt/node@16/bin/npm
Browsers:
Chrome: 106.0.5249.119
Firefox: 103.0.2
Safari: 16.0

Describe the Bug

Deploying to github pages requires a subpath but config.output doesn't exist on viteFinal so where do i set the path from assests? https://poketrax.github.io/tcg-case/ is my deployment and it's looking for /assests/* instead of assets/*

Link to Minimal Reproducible Example

https://github.com/poketrax/tcg-case

Participation

  • I am willing to submit a pull request for this issue.
@jgunzelman88 jgunzelman88 added the bug Something isn't working label Oct 14, 2022
@IanVS
Copy link
Member

IanVS commented Oct 14, 2022

@jgunzelman88 you can set the base to './'. See https://vitejs.dev/config/shared-options.html#base for details.

@yannbf here's an example of an issue that would be solved by storybookjs/storybook#19383

@IanVS IanVS closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants