From ee6935754a6fe5c6ddb818bc5fa0cd059301707e Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 15 Jul 2022 08:20:39 -0700 Subject: [PATCH] Cleanup `peerDependencies` (#445) @storybook/source-loader doesn't need to be in peerDependencies because it's already in dependencies @storybook/core-common and @storybook/node-logger can be just regular dependencies instead of peerDependencies since we don't need the user to add them to their package.json ~~@storybook/mdx1-csf doesn't need to be downloaded by all users. Users will use either @storybook/mdx1-csf or @storybook/mdx2-csf so move it to devDependencies so that users won't end up including it automatically~~ --- packages/builder-vite/package.json | 5 ++--- yarn.lock | 9 ++++----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/builder-vite/package.json b/packages/builder-vite/package.json index dfe3b18f..a49b8e3c 100644 --- a/packages/builder-vite/package.json +++ b/packages/builder-vite/package.json @@ -14,7 +14,9 @@ "homepage": "https://github.com/storybookjs/builder-vite/#readme", "dependencies": { "@joshwooding/vite-plugin-react-docgen-typescript": "0.0.4", + "@storybook/core-common": "^6.4.3", "@storybook/mdx1-csf": "^0.0.4", + "@storybook/node-logger": "^6.4.3", "@storybook/source-loader": "^6.4.3", "@vitejs/plugin-react": "^2.0.0", "ast-types": "^0.14.2", @@ -34,10 +36,7 @@ "vue-docgen-api": "^4.40.0" }, "peerDependencies": { - "@storybook/core-common": ">=6.4.3", "@storybook/mdx2-csf": "^0.0.3", - "@storybook/node-logger": ">=6.4.3", - "@storybook/source-loader": ">=6.4.3", "vite": ">= 3.0.0" }, "peerDependenciesMeta": { diff --git a/yarn.lock b/yarn.lock index 9d87dae6..e6c9d2db 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2857,8 +2857,10 @@ __metadata: resolution: "@storybook/builder-vite@workspace:packages/builder-vite" dependencies: "@joshwooding/vite-plugin-react-docgen-typescript": 0.0.4 + "@storybook/core-common": ^6.4.3 "@storybook/mdx1-csf": ^0.0.4 "@storybook/mdx2-csf": ^0.0.3 + "@storybook/node-logger": ^6.4.3 "@storybook/source-loader": ^6.4.3 "@sveltejs/vite-plugin-svelte": ^1.0.0 "@types/express": ^4.17.13 @@ -2874,10 +2876,7 @@ __metadata: sveltedoc-parser: ^4.2.1 vue-docgen-api: ^4.40.0 peerDependencies: - "@storybook/core-common": ">=6.4.3" "@storybook/mdx2-csf": ^0.0.3 - "@storybook/node-logger": ">=6.4.3" - "@storybook/source-loader": ">=6.4.3" vite: ">= 3.0.0" peerDependenciesMeta: "@storybook/mdx2-csf": @@ -3082,7 +3081,7 @@ __metadata: languageName: node linkType: hard -"@storybook/core-common@npm:6.5.9": +"@storybook/core-common@npm:6.5.9, @storybook/core-common@npm:^6.4.3": version: 6.5.9 resolution: "@storybook/core-common@npm:6.5.9" dependencies: @@ -3403,7 +3402,7 @@ __metadata: languageName: node linkType: hard -"@storybook/node-logger@npm:6.5.9": +"@storybook/node-logger@npm:6.5.9, @storybook/node-logger@npm:^6.4.3": version: 6.5.9 resolution: "@storybook/node-logger@npm:6.5.9" dependencies: